SIGN IN SIGN UP

Revert "[hipGraph] Add graph signal p

=?UTF-8?q?ool=20and=20remove=20pre/post=20markers=20for=20non-=E2=80=A6?=
 =?UTF-8?q?=20(#5333)"=20(#5951)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

## Summary

Reverts #5333 (`f17b05703a`) due to two issues observed in `GraphBench`:

1. **Resource leak.** Per-launch `GraphSignalPool` was deleted via a
forward-declared pointer in `~AccumulateCommand`, so `~GraphSignalPool`
never ran and every per-launch HSA signal was leaked (`Resource leak
detected by SharedSignalPool, N Signals leaked`).
2. **Per-launch host overhead.** Shifting from the runtime's rotating
`signal_list_` (which reuses signals after warmup with `WaitCurrent` +
`WaitNext`) to a per-launch graph signal pool reintroduces N×
`signal_create` + `signal_destroy` on every `hipGraphLaunch`, causing
measurable regression in `graph_bench` across `straight`, `paths2`,
`paths4`, `full2`, `full4` topologies.

A safer redesign that preserves PR #5333's per-launch isolation while
recycling signals (mirroring the runtime pool's `WaitCurrent`/`WaitNext`
discipline) is needed before re-landing.

## Test plan

- [ ] `graph_bench` runs to completion across all five topologies with
no `Signals leaked` warning.
- [ ] `graph_bench` per-launch numbers match pre-PR-#5333 baseline.
- [ ] Existing `hipGraph` unit tests still pass.

Made with [Cursor](https://cursor.com)

Co-authored-by: Cursor <cursoragent@cursor.com>
[rocm-systems] ROCm/rocm-systems#5951 (commit a23a24f)
G
Godavarthy Surya, Anusha committed
7abb112b0dcb432a09ebb9b1dc967db8958df0a7
Parent: c218614
Committed by systems-assistant[bot] <systems-assistant[bot]@users.noreply.github.com> on 5/12/2026, 7:25:17 AM