SIGN IN SIGN UP

Feature/epic fixed folders (#1239)

* Feature/fixed folders (#1199)

* Add example json representing folder structure in docs

* Update model with optional fixed and margin attributes

* Adds first steps to build the map, missing transformation of coordinates

* Refactor improve performance by counting nodes and blacklisted nodes at the same time

* Refactor improve performance by removing one loop

* Fix typo in y properties

* Add coordinate transformation, map is finally visible, but not scalable yet

* Add edges to example json

* Refactor use values in line

* Add size increases based on margin

* Refactor abstract methods and improved readability

* Fix broken tests after changing the method header

* Remove margin since it's not required anymore

* Add snapshot test for fixed folders

* Fix incoming and outgoing edge points are now set correctly

* Fix root folder name should be set based on the root-name of the map

* Presentation add example cc.json

* Presentation rename example cc.json

* Update rename fixed attributes

* Update snapshot since ids are no longer pre-decorated

* Refactor move static functions to helper file
Update jest.config to mock localStorage to test in IntelliJ

* Refactor convert class with static functions to exported objects with functions

* Refactor convert class with static functions to exported objects with functions

* Add no-else-return rule and fix errors

* Refactor use null propagation operator

* Update snapshots and remove unused snapshots

* Update visualization/app/codeCharta/util/treeMapGenerator.spec.ts

Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>

* Update visualization/app/codeCharta/util/fileHelper.ts

Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>

* Refactor rename isNodeToBeFlat to shouldNodeBeFlat

* Refactor use null coalescing to shorten code

* Refactor move shortcut return to the top to improve performance

* Update snapshot after renaming test

* Refactor rearrange function and add return statements to prevent obsolete calculations

* Refactor remove obsolete check in condition if attribute types are empty and added some more tests

* Refactor rename function

Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>

* Docs/fixed-folders (#1163)

* Add documentation on how to generate custom cc.jsons with the fixed attribute

* Fix list not formated correctly

* Update image with x and y coordinates and bounds

* Update remove margin from docs, since it's not required anymore
It is still recommended to apply a margin between folders, but the coordinates of the folders can be set to anything as long as these respect the rules.

* Update gh-pages/_posts/how-to/2020-08-17-fixate-folders-with-a-custom-cc-json.md

Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>

* Update gh-pages/_posts/how-to/2020-08-17-fixate-folders-with-a-custom-cc-json.md

* Update gh-pages/_posts/how-to/2020-08-17-fixate-folders-with-a-custom-cc-json.md

Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>

* Update renamed properties and rephrased explanation on how to set the coordinates

* Update gh-pages/_posts/how-to/2020-08-17-fixate-folders-with-a-custom-cc-json.md

Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>

* Update gh-pages/_posts/how-to/2020-08-17-fixate-folders-with-a-custom-cc-json.md

Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>

* Update docs

* Update gh-pages/_posts/how-to/2020-08-17-fixate-folders-with-a-custom-cc-json.md

Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>

* Update example image and it's corresponding cc.json

Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>

* Feature/fixed folders validation (#1213)

* Add example json representing folder structure in docs

* Update model with optional fixed and margin attributes

* Adds first steps to build the map, missing transformation of coordinates

* Refactor improve performance by counting nodes and blacklisted nodes at the same time

* Refactor improve performance by removing one loop

* Fix typo in y properties

* Add coordinate transformation, map is finally visible, but not scalable yet

* Add edges to example json

* Refactor use values in line

* Add size increases based on margin

* Refactor abstract methods and improved readability

* Fix broken tests after changing the method header

* Remove margin since it's not required anymore

* Add snapshot test for fixed folders

* Fix incoming and outgoing edge points are now set correctly

* Fix root folder name should be set based on the root-name of the map

* Add API.md to document the changes for the cc.json-api

* Update api-versions for tests and files

* Presentation add example cc.json

* Presentation rename example cc.json

* Add validation for fixed folders, not finalized

* Add finalized validation
Fix nodes empty error

* Update collect errors again instead of throwing them instantly

* Update e2e test to use the error messages enum instead of plain strings

* Fix missing whitespace in test of dialog message

* Update rename fixed attributes

* Update snapshot since ids are no longer pre-decorated

* Update tests with renamed fixed attributes

* Refactor move static functions to helper file
Update jest.config to mock localStorage to test in IntelliJ

* Refactor convert class with static functions to exported objects with functions

* Refactor convert class with static functions to exported objects with functions

* Add no-else-return rule and fix errors

* Refactor use null propagation operator

* Update snapshots and remove unused snapshots

* Add eslint rule no-lonely-if and autofix errors

* Update visualization/app/codeCharta/util/treeMapGenerator.spec.ts

Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>

* Update visualization/app/codeCharta/util/fileHelper.ts

Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>

* Refactor rename isNodeToBeFlat to shouldNodeBeFlat

* Refactor use null coalescing to shorten code

* Refactor move shortcut return to the top to improve performance

* Update snapshot after renaming test

* Refactor rearrange function and add return statements to prevent obsolete calculations

* Refactor remove obsolete check in condition if attribute types are empty and added some more tests

* Add e2e test to ensure lower api versions are working without errors or warnings

* Refactor replace custom type KeyValuePair with Record<string, number>

* Update jsonschema

* Refactor replace _.cloneDeep with the rfdc library

* Update snapshot with new api version

* Add fixedPosition attribute of folders resulting in errors during validation after their name for easier debugging

* Fix outOfBounds-Check not checking for negative width and height

* Add another test to ensure the new out of bounds function is working

* Add print found api version when a warning is thrown

* Update visualization/app/codeCharta/util/fileValidator.ts

Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>

* Update remove individual titles and use a generic title for errors and warnings

* Refactor check if both nodes have the fixedPosition attribute before starting calculating overlaps

* Refactor remove obsolete .values() call

* Add found duplicate node to error message
Refactor use a more intuitive implementation to find duplicate nodes
Fix duplicate file in example

* Update snapshot with new file names

* Fix broken e2e test with wrong warning message

* Refactor use root instead of whole file as parameter to validate fixed folders

* Refactor reorder functions

* Revert "Refactor replace custom type KeyValuePair with Record<string, number>"

This reverts commit 061ec816beaacf4329f0b6d9a4af788b575b2b3f.

* Update json schema with KeyValuePair instead of Record again

* Move API.md from visualization to root of project

* Add throw an error if we encountered a fixed folder and the api version is smaller than 1.2

Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>

* Refactor rename file by replacing - with _ in the name

* Update CHANGELOG

* Update CHANGELOG, api version incremented

* Docs move api change to Changed section

* Update outdated property names

Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
B
Ben Willenbring committed
25a96672eb9a879b241cc91a84bb3ccc29150f13
Parent: 238a05c
Committed by GitHub <noreply@github.com> on 9/11/2020, 9:10:11 AM