SIGN IN SIGN UP
facebook / react-native UNCLAIMED

A framework for building native applications using React

0 0 151 C++

Rename DrawCommandSpan to CanvasEffectSpan and remove UpdateAppearance (#56705)

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/56705

Changelog: [Internal]

Renames `DrawCommandSpan` to `CanvasEffectSpan` for consistency with the new
`AnimatedEffectSpan`, and removes the `UpdateAppearance` interface.

`UpdateAppearance` is a marker interface that tells Android's text layout system
the span affects text appearance (triggering re-measurement). Since
`CanvasEffectSpan` only draws on top of text during `PreparedLayoutTextView`'s
draw pass and never modifies paint state or text measurement, implementing
`UpdateAppearance` was incorrect — the same reasoning applied when designing
`AnimatedEffectSpan` without it.

Reviewed By: mdvacca

Differential Revision: D97399655

fbshipit-source-id: 3865b4143d696d519abdff9a6471dbe3a9867d6f
A
Andrew Datsenko committed
7ae9b664e9001e0467647506913b417967ed2c4f
Parent: 71a0d5d
Committed by meta-codesync[bot] <215208954+meta-codesync[bot]@users.noreply.github.com> on 5/6/2026, 5:27:55 PM