SIGN IN SIGN UP
facebook / react-native UNCLAIMED

A framework for building native applications using React

0 0 0 C++

Fix infinite recursion in ReactPropAnnotationSetterSpecTest (#55662)

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/55662

Fix infinite recursion bugs in `ReactPropAnnotationSetterSpecTest.kt`:

- `createShadowNodeInstance()` (line 25): Method calls itself recursively instead of creating a shadow node instance. Fixed to return `ReactShadowNodeImpl()`, which is the concrete implementation of `ReactShadowNode`.
- `createViewInstance(reactContext)` (line 30): Method calls itself recursively instead of creating a view instance. Fixed to return `View(reactContext)`, which creates a basic Android View.

Both methods are in an abstract inner `BaseViewManager` test class used to satisfy the `ViewManager` abstract contract. The test class is only used to verify `ReactProp` annotation validation, so these methods just need to return valid instances.

Detected by InfiniteRecursion lint detector (D93897169).

Changelog:
[Internal] -

Reviewed By: cortinico

Differential Revision: D93927939

fbshipit-source-id: b971f1fbc9e0c216e2cb9db642f34a6cbf38394a
R
Ron Edelstein committed
aabdf55f0dbd9dcfbf2a50a0c67b8b79bdd4fc88
Parent: 352d73b
Committed by meta-codesync[bot] <215208954+meta-codesync[bot]@users.noreply.github.com> on 2/23/2026, 10:09:45 AM