A framework for building native applications using React
Support loading vector drawables in ImageView (#45354)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/45354 Fresco has indicated that they have no plans to support loading vector assets and similar drawable types in Drawee-backed views ([issue](https://github.com/facebook/fresco/issues/329), [issue](https://github.com/facebook/fresco/issues/1463), [issue](https://github.com/facebook/fresco/issues/2463)). Guidance has been to instead load the vector drawable onto the backing image view ourselves. On the React Native side, having the ability to load vector drawables has been requested many times ([issue](https://github.com/facebook/react-native/issues/16651), [issue](https://github.com/facebook/react-native/issues/27502)). I went this route over using a custom Fresco decoder for XML assets because vector drawables are compiled down into binary XML and I couldn't find a trivial, performant way to parse those files in a context-aware manner. This change only accounts for vector drawables, not any of the other XML-based drawable types (layer lists, level lists, state lists, 9-patch, etc.). Support could be added easily in the future by expanding the `getDrawableIfUnsupported` function. ## Changelog [Android] [Added] - Added support for rendering XML assets provided to `Image` Reviewed By: javache Differential Revision: D59530172 fbshipit-source-id: 3d427c06238287e0a3b7f9570ac20e43d76126c7
P
Peter Abbondanzo committed
aad9240fd435d549812b5075767c5ea39a8fbb4f
Parent: cbcdb38
Committed by Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
on 7/15/2024, 3:54:48 PM