SIGN IN SIGN UP
facebook / react-native UNCLAIMED

A framework for building native applications using React

0 0 155 C++

Refactor LazyTurboModuleManagerDelegate to avoid holding references to TurboModules (#41181)

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/41181

The goal of this refactor is to ensure that LazyTurboModuleManagerDelegate doesn't hold references to TurboModules.

EveryTime that LazyTurboModuleManagerDelegate.getModule is called, it will create a new TurboModule. This 'should' be fine because the references to already created TurboModules are held on
TurboModuleManager.mModuleHolders.

As part of this diff I'm also throwing an exception when the method LazyTurboModuleManagerDelegate.unstable_isModuleRegistered is called. This should be fine because I ensured that
"LazyTurboModuleManagerDelegate.unstable_isModuleRegistered' is not called for this experiment.

changelog: [internal] internal

Reviewed By: RSNara

Differential Revision: D50610163

fbshipit-source-id: 8d9d808b9b637c8e9bc3fd9c2502793161cac42c
D
David Vacca committed
c999535fe6ad2503ba0594d609dec0c63d547112
Parent: 833d589
Committed by Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> on 10/25/2023, 4:12:55 AM