A framework for building native applications using React
Fix `display: contents` nodes not being cloned with the wrong owner (#52530)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/52530 This PR fixes two issues with `display: contents` implementation: 1. When a node with `display: contents` set is a leaf, it won't be cloned after the initial tree is built. The added test case covers this scenario. 2. It was possible for the subtree of `display: contents` nodes not to be cloned during layout. I don't have a minimal reproduction for this one, unfortunately. It was discovered in the Expensify app: https://github.com/Expensify/App/issues/65268, along with a consistent reproduction. In that specific case, it seems to be heavily tied to `react-native-onyx`, which is a state management library. Changelog: [GENERAL][FIXED] - Fixed nodes with `display: contents` set being cloned with the wrong owner X-link: https://github.com/facebook/yoga/pull/1826 Reviewed By: adityasharat, NickGerleman Differential Revision: D78084270 Pulled By: j-piasecki fbshipit-source-id: eb81f6d7dcd1665974d07261ba693e2abea239bb
J
Jakub Piasecki committed
d4b36b03003eb2de9eaf5b57bb639bae8cc12f20
Parent: 84a2765
Committed by Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
on 7/11/2025, 9:16:35 AM