2 Commits

Author	SHA1	Message	Date
kacperkapusciak	3f78fa953a	Fix checkForReproducer action not adding Missing Repro comment (#38531) ... Summary: This PR fixes a bug where GitHub Actions bot didn't add a comment when "Needs: Repro" label was present in an issue. When a maintainer adds the label manually the bot comments with "Missing Reproductible Example" as normally. It seems like the problem occurred because of a difference in a sandbox repository and the proper facebook/react-native repo environment. My sandbox that I used to test https://github.com/facebook/react-native/pull/38338 had an "bot" account with Personal Access Token setup to reply to issues. Turns out that bots using PAT have more permissions and can trigger one action from the other. **The solution is to send the comment directly from the `checkForReproducer` action.** This won't collide with other actions but sadly will duplicate the sending logic into two actions. This PR also makes the bot respect when a maintainer removes and adds a label by hand and won't alter the maintainer decision. Related to ☂️ https://github.com/facebook/react-native/issues/35591 ## Changelog: [INTERNAL] [FIXED] - Message Pull Request resolved: https://github.com/facebook/react-native/pull/38531 Test Plan:  Reviewed By: cipolleschi Differential Revision: D47666922 Pulled By: cortinico fbshipit-source-id: 4a6a471cb11c6ed9b48263d18bf8e283577a14bb	2023-07-21 08:46:03 -07:00
kacperkapusciak	42a2898617	Add check-for-reproducer action (#38338) ... Summary: This PR adds a "check-for-reproducer" GitHub action proposed in https://github.com/facebook/react-native/issues/35591. This GitHub action automatically labels an issue with when no link to GitHub repository under the authors name or link to Snack is present either in the issue body or in the comments. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [INTERNAL] [ADDED] - Add check-for-reproducer GitHub action Pull Request resolved: https://github.com/facebook/react-native/pull/38338 Test Plan: This action was tested on a private repro mimicking on how GitHub actions are set-up in `facebook/react-native` repository. If you'd want to play around with the action on this private repo just ask for access - provided you're a maintainer. ### Regarding issue body 1. Labels "Needs: Repro" when no link to Expo Snack or a Github repo under the author's name is present in the issue body:  2. Removes the "Needs: Repro" label and deletes the Missing Repro comment when the author edits the issue and provides a link to GitHub repo under their name  3. Removes the "Needs: Repro" label and deletes the Missing Repro comment when the author edits the issue and provides a valid link to Expo Snack  ### Regarding comments 3. Removes the "Needs: Repro" label and deletes the Missing Repro comment when there's a comment with a link to reproduction under issue author's name  4. Removes the "Needs: Repro" label and deletes the Missing Repro comment when there's a comment with a link to Expo Snack  ### Regarding false-positives 5. Adds a "Needs: Repro" label when a link to reprository isn't under the issue author's name  6. Adds a "Needs: Repro" label when a link to Expo Snack's homepage was sent  7. Adds a "Needs: Repro" label when a random link was sent  Reviewed By: NickGerleman Differential Revision: D47511745 Pulled By: cortinico fbshipit-source-id: 2c0e5a989f52b4e50992a3954283f122b14153e0	2023-07-19 02:38:28 -07:00