SIGN IN SIGN UP
facebook / react UNCLAIMED

The library for web and native user interfaces.

0 0 0 JavaScript

[compiler] Prevent innaccurate derivation recording on FunctionExpressions on no-derived-computation-in-effects

Summary:
The operands of a function expression are the elements passed as context. This means that it doesn't make sense to record mutations for them.

The relevant mutations will happen in the function body, so we need to prevent FunctionExpression type instruction from running the logic for effect mutations.

This was also causing some values to depend on themselves in some cases triggering an infinite loop. Also added a safeguard to prevent this issue

Test Plan:
Added fixture test
J
Jorge Cabiedes Acosta committed
2f940411c2a7e50cc5a1a62351d00a08df9445c6
Parent: 8ac5f4e