SIGN IN SIGN UP
facebook / react UNCLAIMED

The library for web and native user interfaces.

0 0 0 JavaScript

Make prerendering always non-blocking with fix (#31452)

We've previously failed to land this change due to some internal apps
seeing infinite render loops due to external store state updates during
render. It turns out that since the `renderWasConcurrent` var was moved
into the do block, the sync render triggered from the external store
check was stuck with a `RootSuspended` `exitStatus`. So this is not
unique to sibling prerendering but more generally related to how we
handle update to a sync external store during render.

We've tested this build against local repros which now render without
crashes. We will try to add a unit test to cover the scenario as well.

---------

Co-authored-by: Andrew Clark <[email protected]>
Co-authored-by: Rick Hanlon <[email protected]>
J
Jack Pope committed
989af12f72080c17db03ead91d99b6394a215564
Parent: 5c56b87
Committed by GitHub <[email protected]> on 11/8/2024, 5:38:41 PM