A powerful cross-platform UI toolkit for building native-quality iOS, Android, and Progressive Web Apps with HTML, CSS, and JavaScript.
fix(select): ensure select sizes are respected when the label is empty (#30087)
Issue number: internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Currently, the experience planned for ionic select has the sizes fixed and should be respected even when the labels are not presented. https://stackblitz.com/edit/ku3fqz?file=src%2Fmain.tsx ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - When select is used with Ionic-theme, the select should respect the height sizes established. - https://stackblitz.com/edit/ku3fqz-2vnasdmx?file=package-lock.json,package.json - https://ionic-framework-cdtf7hsqy-ionic1.vercel.app/src/components/select/test/size?ionic:theme=ionic ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> --------- Co-authored-by: Maria Hutt <maria@ionic.io>
J
João Ferreira committed
3f00e696ca1d3c4e9ade763d788ffaa6039c410a
Parent: b7da1e8
Committed by GitHub <noreply@github.com>
on 12/20/2024, 5:05:08 PM