A powerful cross-platform UI toolkit for building native-quality iOS, Android, and Progressive Web Apps with HTML, CSS, and JavaScript.
test(datetime): un-flake presentation test (#28090)
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> There are two problems with this test: 1. The screenshots are not capturing the correct UI. For example, the following screenshot should capture the date and time grid picker, but it's only capturing the year wheel picker: https://github.com/ionic-team/ionic-framework/blob/8ab3476ac7e9b05aba5328c31db763011dc0a766/core/src/components/datetime/test/presentation/datetime.e2e.ts-snapshots/datetime-presentation-date-time-diff-ios-rtl-Mobile-Safari-linux.png 2. These screenshots are flaky. This is possibly due to how they were written where they iterate through an array, select a value from the `select`, and then wait a timeout for the view to change. 3. I also discovered that we'll have some visual diffs once 2024 hits. The current value of the datetime on the wheel picker is 2022. 2023 is shown, but 2024 is not (since we are still in 2023). Once Jan 1 2024 hits, these tests will likely start to fail with visual diffs. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Refactored these tests to use a test fixture where each presentation is a separate test. This ensures that the tests are correct. Because there is less interaction going on with the page (i.e. the correct presentation is set on load), my hope is that this also reduces test flakiness. - Also changed the date used to be several years ago so we don't have new years showing up in the wheel picker screenshots as time goes on. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> --------- Co-authored-by: ionitron <hi@ionicframework.com>
L
Liam DeBeasi committed
e1fdbb344ab5e722b2c924abaabd6b9c79aa69cd
Parent: 2a80eb6
Committed by GitHub <noreply@github.com>
on 8/31/2023, 4:03:41 PM