Fix for duplicated dockbands (#46438)
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request CommandProviderWrapper.PinDockBand had no duplicate check and it blindly called .Add() on the settings list every time. This allowed the same extension to be pinned multiple times to the dock. Once duplicates existed in settings, LoadTopLevelCommands would faithfully re-create all of them on every CommandsChanged reload, making edit-mode unpin appear broken (unpin removes one, reload brings them all back). **Fix** - CommandProviderWrapper.PinDockBand: Check all three band lists (Start/Center/End) for an existing (ProviderId, CommandId) match before adding; early-return if already pinned. - CommandProviderWrapper.LoadTopLevelCommands: Track seen command IDs in a HashSet when iterating AllPinnedCommands; skip duplicates so they never materialize in the UI even if present in settings. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [ ] Closes: #xxx <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed --------- Co-authored-by: Jiří Polášek <[email protected]>
N
Niels Laute committed
2cf7d0f5ec7b4a5ef953130b7039c2ed1d1f35bd
Parent: 7cb0f38
Committed by GitHub <[email protected]>
on 3/25/2026, 5:29:55 PM