Commit Graph

27 Commits

Author SHA1 Message Date
Dileep Yavanmandha
5270d49008 Agent sandboxing: detect missing dependencies before execution and offer installation 2026-03-27 14:07:29 -07:00
Benjamin Pasero
c136539a3f docs - add service dependency declaration guideline (#305682)
* docs - add service dependency declaration guideline

* Update .github/copilot-instructions.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-03-27 16:05:42 +00:00
Benjamin Pasero
bf5f2dc920 docs - update copilot instructions for event usage (#303252) 2026-03-19 20:06:52 +01:00
Benjamin Pasero
9495e313c0 sessions - clarify instructions around compiling and testing (#299255) 2026-03-04 11:45:50 -08:00
Benjamin Pasero
0d35e5d19e eng - explain fallback for how to check for compilation issues fast in CLI envs (#299117)
* eng - explain fallback for how to check for compilation issues fast in CLI envs

* Update .github/copilot-instructions.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update .github/copilot-instructions.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* .

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-03-04 07:51:24 +01:00
Benjamin Pasero
06c96dcab4 sessions - AI customizations for selfhost (#299053)
* sessions - AI customizations for selfhost

* more

* Update .github/hooks/hooks.json

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update .github/skills/sessions/SKILL.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-03-04 05:56:19 +01:00
João Moreno
d2f1f7ce97 Inline Compile & CompileCLI stages into platform specific jobs (#296006)
* chore: ralph loop checkpoint - 2026-02-17 12:48

* fix shell script

* Inline compile stage into platform jobs

Remove the standalone Compile stage from the ADO pipeline. Each
platform job (Windows, Linux, macOS, Alpine, Web) now compiles
TypeScript itself instead of downloading a shared Compilation artifact.

- Add VSCODE_RUN_CHECKS parameter to Linux jobs for hygiene/lint/CG
- Add VSCODE_RUN_COMPILE_EXTRAS parameter to macOS jobs for telemetry
  extraction and sourcemap upload
- Remove VSCODE_COMPILE_ONLY parameter entirely
- Delete product-compile.yml (no longer referenced)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Always run telemetry extraction on macOS builds

The macOS Universal app merge requires both x64 and arm64 builds to have
identical file sets. Telemetry extraction was only running on arm64 (via
VSCODE_RUN_COMPILE_EXTRAS), causing the universal merge to fail due to
missing telemetry-core.json and telemetry-extensions.json in the x64 build.

Move telemetry extraction outside the VSCODE_RUN_COMPILE_EXTRAS gate so
it runs on all macOS builds. Sourcemap upload remains gated.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Run telemetry extraction on all client builds

All client builds (Linux, Windows, macOS) need telemetry-core.json and
telemetry-extensions.json. Previously only macOS arm64 ran extract-telemetry.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Only run telemetry extraction on Linux x64 (client build)

Linux arm64 and armhf are server-only builds, no need for telemetry files.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Remove .ralph scaffolding files

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Fix telemetry extraction on Windows with native PowerShell

The bash extract-telemetry.sh script fails on Windows because the Unix
bin shim gets interpreted as Node.js code. Use a native PowerShell
implementation that calls the extractor JS entry point directly.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Handle missing telemetry files gracefully on Windows

The telemetry extractor may skip emitting declarations-resolved.json
when no events are found. Handle this case with a warning instead of
failing the build.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Use deterministic build date from git commit timestamp

When each platform compiles independently, the build date embedded in
cli.js (via INSERT_PRODUCT_CONFIGURATION) differs between machines
because each uses new Date().toISOString(). This causes the macOS
Universal app merge to fail since cli.js SHA differs between x64/arm64.

Fix: use the git commit date (git log -1 --format=%cI HEAD) instead
of the current wall-clock time. This ensures all independent builds
on different machines produce identical timestamps.

Updated in:
- build/lib/date.ts: writeISODate() uses git commit date
- build/next/index.ts: bundle(), transpile, and readISODate fallback
  all use git commit date

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Remove redundant extensions-ci task from CI pipelines

core-ci (esbuild path) already includes cleanExtensionsBuildTask,
compileNonNativeExtensionsBuildTask, and compileExtensionMediaBuildTask.
Running extensions-ci in parallel caused a race condition where
core-ci's rimraf of .build/extensions clashed with extensions-ci
writing to the same directory.

Also removes dead code:
- extensions-ci and extensions-ci-pr task definitions (fully subsumed)
- core-ci-old task (useEsbuildTranspile is always true)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* remove VSCODE_RUN_COMPILE_EXTRAS

* address PR feedback regarding code duplication of `getGitCommitDate()` function by exporting a single helper function from `build/lib/date.ts` and importing it in `build/next/index.ts` to ensure consistent behavior and improve code maintainability.

* update readISODate function to return git commit date instead of current date

* add telemetry sorting script and integrate into build process for consistent output

* refactor telemetry extraction process: replace shell script with TypeScript implementation

* update skill

* update telemetry-extractor dependency to version 1.19.0

* fix build

* fix more duplicate telemetry definition issues

* cleanup

* refactor: consolidate validation checks into quality checks and remove obsolete tasks

* bust the cache

* undo cache bust

* fix expression

* fix

* fix: update Azure storage account name in quality checks

* fix: initialize stages set with 'Quality'

* fix: add VSCODE_BUILD_TYPE parameter with options for Product and CI builds

* fix: update Azure Pipeline CLI to use parameters instead of variables for queueing builds

* fix: update VSCODE_BUILD_TYPE parameter values for clarity

* fix: update default value for VSCODE_BUILD_TYPE parameter to 'Product'

* leaner

* even leaner

* only npm ci in build

* 💄

* run entire npm ci

* fix

* fix

* fix it

* Inline CompileCLI into platform stages

- Remove centralized CompileCLI stage
- Move CLI jobs into Windows, Linux, macOS stages as independent jobs
- CLI jobs now compile, publish unsigned mid-job, sign, and publish signed
- Platform compile jobs use deemon + waitForArtifacts for async CLI download
- Delete separate CLI sign jobs (now merged into CLI compile jobs)
- Remove CompileCLI from publish.ts stage tracking

* fix: macOS CLI signing - use proper directory structure for ESRP

* fix: add BUILDS_API_URL to Windows and Linux job templates

* fix: label Linux CLI jobs clearly

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: João Moreno <22350+joaomoreno@users.noreply.github.com>
2026-03-01 08:48:08 +01:00
Benjamin Pasero
b482c86053 chat - update instructions (#296995)
* chat - update instructions

* Update .github/copilot-instructions.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-02-23 15:25:06 +00:00
Benjamin Pasero
73e3dbe7a2 sessions - adopt modal editor support from core (#296585)
* sessions - adopt modal editor support from core

* Update src/vs/workbench/services/editor/test/browser/modalEditorGroup.test.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update .github/skills/agent-sessions-layout/SKILL.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update src/vs/workbench/services/editor/common/editorGroupFinder.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-02-20 19:47:52 +00:00
Benjamin Pasero
c534163aad update instructions (#291715)
* update instructions

* .
2026-01-29 21:19:58 +01:00
Benjamin Pasero
05e03affb1 docs - add guidance for handling disposables (#290336) 2026-01-26 00:51:51 -08:00
João Moreno
88fa47422c Support overwrite updates on DarwinUpdateService (#288129)
* Update DarwinUpdateService to handle pending updates during checks and errors

* wip: test update server

* refactor: remove pending update handling from DarwinUpdateService

* show action

* feat: enhance update service to support explicit and overwrite states

* feat: add redirect functionality to update server

* fix: when checking for newer update, make the right call against the update service

also add logs since we're not getting the commit id :(

* fix: darwin auto update should use correct commit version

* fix: cleanup the code a bit

* updates

* feat: add Overwriting state to update process and update related logic

* fix: enhance update check with cancellation support and timeout handling

* nit: language

* do not attempt to overwrite updates twice

* remove test update server scripts
2026-01-22 16:50:50 +01:00
Henning Dieterichs
92e1dfc80f updates learnings (#287749) 2026-01-14 11:38:21 +00:00
Benjamin Pasero
67c15fe860 instructions - make it clear to reuse code and not duplicate (#286131) 2026-01-06 13:17:55 +00:00
Dmitriy Vasyura
bf9b541a0f Add instructions for file watchers and tooltips 2025-12-15 01:22:34 -08:00
Benjamin Pasero
752c9ea03e copilot instructions update (#280247) 2025-12-01 15:45:45 +08:00
Alex Ross
c15daf9d6d Regex capture groups (#275609) 2025-11-05 16:36:53 +00:00
Benjamin Pasero
898436fbe6 Clean up code layering suppressions (fix #272777) (#272834)
* Clean up code layering suppressions (fix #272777)

* Update test/unit/electron/index.js

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-10-23 09:28:38 +02:00
Harald Kirschner
f8b5d7523f Refactor Build task instructions with tool references 2025-10-15 16:59:41 -07:00
Megan Rogge
f8207b7f49 discourage agent from using any/unknown casts in instructions (#269122)
add rule about as any/unknown
2025-09-30 16:38:12 +00:00
Benjamin Pasero
10b637cc5d ai - clarify how to deal with strings in instructions (#267248) 2025-09-17 10:41:06 -07:00
Alexandru Dima
b56ca46cb1 Always prefer using the run test tool (#266994) 2025-09-15 23:05:35 +00:00
Harald Kirschner
74a2c8640f Update instructions for builds (#262638)
* Add more validation instructions

* Fix validation instructions numbering

* Refined validation instructions
2025-08-25 08:50:22 +02:00
Benjamin Pasero
b50ac5ac92 Explore to support desktop notifications when in agent mode (#251621) (#255643) 2025-07-14 11:45:53 +00:00
Benjamin Pasero
ee88620afc debt - improve workspace settings and copilot configuration (#255359) 2025-07-12 12:40:46 -07:00
Johannes Rieken
7ef3228c7f remove API guidelines from copilot instructions (#235475) 2024-12-06 11:25:23 +01:00
Christof Marti
3b8bbd953e Add Copilot instructions 2024-11-28 11:54:55 +01:00