SIGN IN SIGN UP
facebook / react UNCLAIMED

The library for web and native user interfaces.

0 0 0 JavaScript

Remove noinline directives from new commit phase (#20241)

My theory for too much inlining contributing to overall stack size is
likely flawed, because Closure reuses variables within a function to
optimize registers.

Even if my theory were correct, the impact would be minimal anyway
because the recursive implementation of the commit phase traversals is
behind a disabled feature flag.

Going to revert this. We can maybe test the impact once we land the
commit phase changes. In the meantime, I'd prefer to eliminate this
delta from the new fork.
A
Andrew Clark committed
1b96ee444e544cc4797bbbd8dee249ff02d62279
Parent: e41fd1f
Committed by GitHub <noreply@github.com> on 11/12/2020, 6:21:56 PM