clean-code-javascript

ryanmcdermott/clean-code-javascript

Fork 0

mirror of https://github.com/ryanmcdermott/clean-code-javascript.git synced 2026-04-07 14:08:15 +00:00

Commit Graph

Select branches

Hide Pull Requests

master

#1

#10

#100

#100

#101

#102

#103

#103

#104

#105

#106

#106

#109

#109

#11

#110

#110

#111

#114

#116

#116

#117

#117

#118

#119

#119

#12

#12

#120

#121

#123

#124

#127

#128

#13

#13

#132

#132

#134

#137

#139

#14

#14

#140

#141

#142

#142

#144

#145

#147

#149

#15

#15

#151

#151

#152

#153

#154

#154

#155

#155

#156

#157

#16

#164

#164

#165

#166

#167

#169

#169

#17

#170

#170

#171

#172

#173

#174

#174

#176

#177

#178

#178

#179

#179

#18

#182

#183

#186

#187

#188

#189

#189

#19

#191

#191

#192

#193

#194

#194

#195

#195

#196

#197

#198

#20

#202

#204

#206

#207

#208

#208

#209

#21

#210

#211

#213

#213

#215

#216

#217

#218

#218

#219

#22

#220

#221

#222

#223

#223

#224

#225

#226

#227

#228

#229

#232

#233

#234

#238

#239

#24

#240

#240

#243

#244

#246

#247

#248

#251

#251

#253

#254

#255

#256

#257

#258

#259

#26

#261

#262

#263

#264

#265

#267

#268

#269

#27

#270

#272

#273

#274

#276

#277

#279

#28

#280

#283

#284

#284

#287

#288

#289

#29

#290

#291

#297

#3

#310

#311

#312

#313

#318

#32

#320

#322

#323

#324

#325

#326

#327

#33

#331

#332

#333

#338

#339

#34

#341

#342

#344

#344

#345

#345

#346

#347

#348

#349

#349

#35

#352

#353

#353

#355

#356

#357

#357

#36

#36

#361

#361

#364

#364

#365

#365

#368

#369

#369

#37

#374

#375

#375

#376

#377

#377

#379

#379

#38

#38

#383

#385

#385

#386

#386

#39

#392

#394

#394

#395

#395

#397

#398

#399

#400

#400

#401

#401

#402

#402

#403

#403

#404

#404

#408

#408

#409

#412

#412

#413

#413

#415

#415

#417

#417

#419

#419

#421

#421

#424

#424

#426

#426

#427

#427

#428

#428

#43

#436

#436

#439

#439

#44

#44

#440

#442

#442

#443

#443

#447

#447

#448

#448

#450

#453

#453

#454

#454

#456

#456

#457

#457

#46

#47

#48

#48

#486

#486

#51

#53

#54

#56

#57

#57

#58

#6

#60

#61

#61

#62

#63

#63

#64

#65

#66

#67

#67

#68

#68

#69

#693

#693

#694

#694

#696

#696

#697

#697

#698

#698

#7

#7

#703

#703

#704

#704

#707

#709

#717

#718

#718

#719

#719

#72

#72

#720

#720

#721

#721

#722

#722

#727

#728

#728

#73

#73

#76

#77

#77

#79

#8

#80

#81

#82

#83

#84

#86

#87

#88

#89

#89

#9

#9

#90

#91

#92

#93

#94

#95

#96

#97

#98

#99

#99

3b42f996f7 Merge pull request #141 from vsemozhetbyt/nits Ryan McDermott 2017-01-14 19:54:08 -08:00
ba3e34fcf4 fix some code style nits in examples Vse Mozhet Byt 2017-01-15 05:49:55 +02:00
b1b37eb234 Make meaningful variable example even clearer Ryan McDermott 2017-01-14 15:34:05 -08:00
2721980572 Merge pull request #140 from krzysztof-grzybek/master Ryan McDermott 2017-01-14 15:32:21 -08:00
aa71b3068c modify open/closed principle krzysztof-grzybek 2017-01-14 21:19:37 +01:00
3364af5f98 Remove stark warning against duplicate code, let's just strongly suggest to avoid it Ryan McDermott 2017-01-14 11:18:35 -08:00
84f8ea6f8d Simplify "Use searchable names" example (#121) Crisoforo Gaspar Hernández 2017-01-14 11:50:51 -06:00
aa069b37d4 Merge pull request #128 from ianstormtaylor/patch-1 Ryan McDermott 2017-01-14 09:25:39 -08:00
e94afcf3cf Change literal for a constant Marc Aragonès 2017-01-14 17:30:25 +01:00
dd47a0d0f4 Merge pull request #134 from ejribeiro/master Ryan McDermott 2017-01-13 07:33:24 -08:00
9becf1c0d8 Fix lookupManager typo ribeiroje 2017-01-13 12:34:59 +00:00
7ec1fe7a62 Merge pull request #83 from iamken1204/fill-missing-commas Ryan McDermott 2017-01-12 20:26:53 -08:00
e550f1ea79 merge origin Kettan 2017-01-13 11:59:43 +08:00
ab48c4c86d Merge pull request #118 from vasanthk/master Ryan McDermott 2017-01-12 19:29:40 -08:00
a09a69685b Merge pull request #124 from vsemozhetbyt/diff Ryan McDermott 2017-01-12 19:14:40 -08:00
d97805d66e Remove Law of Demeter Ryan McDermott 2017-01-12 19:13:14 -08:00
6774f750f2 fix async/await example Ian Storm Taylor 2017-01-12 17:16:48 -08:00
54aed62267 make bad and old examples more comparable Vse Mozhet Byt 2017-01-12 13:02:44 +02:00
e8812779b5 Add Side Effects pt.2 Kostas Bariotis 2017-01-12 11:50:55 +02:00
30e7a39bf2 Fix naming for bad code as well Vasa 2017-01-11 22:27:32 -08:00
cd50889707 Merge pull request #65 from vsemozhetbyt/simplify Ryan McDermott 2017-01-11 21:52:19 -08:00
08601465f3 Merge pull request #114 from vsemozhetbyt/new-clean Ryan McDermott 2017-01-11 21:39:20 -08:00
783f7c5895 Merge branch 'master' into new-clean Ryan McDermott 2017-01-11 21:39:02 -08:00
e7ef70e367 Merge pull request #120 from JakoD/master Ryan McDermott 2017-01-11 21:33:07 -08:00
05089ba5de "Use searchable names" and correct unit of time Jako Danar 2017-01-12 02:36:50 +01:00
7761d2499e Fix erroneous line break Vasa 2017-01-11 11:12:09 -08:00
887c779bad Rename state to zipCode to avoid confusion Vasa 2017-01-11 10:19:50 -08:00
6fcbecea0e fix new instances of previously fixed cases Vse Mozhet Byt 2017-01-11 15:15:29 +02:00
383dd49144 Merge pull request #64 from HemantPawar/master Ryan McDermott 2017-01-10 20:44:06 -08:00
e4100a30ad Merge pull request #111 from irazasyed/patch-1 Ryan McDermott 2017-01-10 20:41:54 -08:00
34abb0bbb8 Fix Typo Syed Irfaq R. ⚡️ 2017-01-11 10:09:25 +05:30
0b3aba1ae9 Merge branch 'master' into master Hemant Pawar 2017-01-11 09:15:08 +05:30
50850a9370 Fix unorganized list in Objects section Ryan McDermott 2017-01-10 19:44:21 -08:00
50e5c1b02e Merge pull request #33 from wordofchristian/patch-1 Ryan McDermott 2017-01-10 19:30:48 -08:00
cea298d2bc Merge pull request #37 from SebastienElet/feat/use-destructuring Ryan McDermott 2017-01-10 19:29:27 -08:00
67942527ae Merge pull request #34 from acparas/master Ryan McDermott 2017-01-10 19:23:08 -08:00
f93513e68d Fix argument ordering Ryan McDermott 2017-01-10 19:21:13 -08:00
bf749576cd Merge pull request #47 from Tarabass/master Ryan McDermott 2017-01-10 19:20:23 -08:00
f350f2be8a Merge branch 'master' into master Ryan McDermott 2017-01-10 19:20:05 -08:00
0c4fa28c0e Merge pull request #81 from vsemozhetbyt/arrow-parens Ryan McDermott 2017-01-10 19:17:44 -08:00
99bee74a41 Merge pull request #82 from vsemozhetbyt/prefer-template Ryan McDermott 2017-01-10 19:16:50 -08:00
87d6d3bbd7 Merge pull request #95 from vsemozhetbyt/anon-functions Ryan McDermott 2017-01-10 19:16:04 -08:00
7fe566c5bc Fix extra good example in getters and setters Ryan McDermott 2017-01-10 19:10:11 -08:00
0951bc270a Merge pull request #101 from kurtommy/fix/getter-setter Ryan McDermott 2017-01-10 19:05:01 -08:00
ce4315fd61 function name change Tommaso Rossi 2017-01-10 22:58:49 +01:00
fda83577a4 Update README.md Tommaso Rossi 2017-01-10 22:56:52 +01:00
eaa3477dbf Lower "bad example" count Anton Paras 2017-01-10 08:53:09 -08:00
aec7b4c420 fix misspelled property name Vse Mozhet Byt 2017-01-10 17:35:47 +02:00
f5e59ee9ea Merge pull request #90 from vsemozhetbyt/single-quotes Ryan McDermott 2017-01-10 07:22:44 -08:00
3bf55e0751 Merge pull request #93 from vsemozhetbyt/brace-style Ryan McDermott 2017-01-10 07:20:57 -08:00
8f7c8cee15 Merge pull request #102 from othree/master Ryan McDermott 2017-01-10 07:19:37 -08:00
58ace72293 Merge pull request #105 from checkaayush/fix-typo Ryan McDermott 2017-01-10 07:12:19 -08:00
b326ee5a53 Fix consecutive occurrence of 'have' Aayush Sarva 2017-01-10 19:53:06 +05:30
f70ac09982 Merge branch 'master' into master Hemant Pawar 2017-01-10 17:45:45 +05:30
23e0da3379 Use console.error to deal with error othree 2017-01-10 18:04:55 +08:00
e56b69e4a7 Added real getter and setter Tommaso Rossi 2017-01-10 10:25:53 +01:00
d7b8cc1ea0 Update README.md Tommaso Rossi 2017-01-10 10:23:16 +01:00
1f1cd46a25 Merge branch 'master' into anon-functions Vse Mozhet Byt 2017-01-10 10:11:43 +02:00
44c324128b Merge branch 'master' into brace-style Vse Mozhet Byt 2017-01-10 10:09:59 +02:00
0b5587274d Merge branch 'master' into single-quotes Vse Mozhet Byt 2017-01-10 10:06:41 +02:00
fcfab4e44e Merge pull request #91 from vsemozhetbyt/eqeqeq Ryan McDermott 2017-01-09 19:41:51 -08:00
c613772562 Merge pull request #88 from vsemozhetbyt/class-methods-use-this Ryan McDermott 2017-01-09 19:41:16 -08:00
d971254397 Merge pull request #92 from vsemozhetbyt/break Ryan McDermott 2017-01-09 19:38:37 -08:00
847e340f90 Merge pull request #94 from vsemozhetbyt/operator-assignment Ryan McDermott 2017-01-09 19:38:05 -08:00
3f94eb22f4 Merge pull request #96 from vsemozhetbyt/no-use-before-define Ryan McDermott 2017-01-09 19:26:50 -08:00
2d59de73e2 Merge pull request #97 from vsemozhetbyt/no-shadow Ryan McDermott 2017-01-09 19:18:52 -08:00
bfa3eb307c Merge pull request #98 from danielstjules/magic-numbers Ryan McDermott 2017-01-09 19:13:57 -08:00
63b46b5871 Mention buddy.js and ESLint for magic numbers Daniel St. Jules 2017-01-09 16:43:32 -08:00
ac12cb8137 Merge branch 'master' into master Anton Paras 2017-01-09 17:04:19 -08:00
bd5d9ef48d Fix package name, s/jsinpect/jsinspect Daniel St. Jules 2017-01-09 16:39:34 -08:00
25791b0361 fix variable shadowing Vse Mozhet Byt 2017-01-09 20:38:17 +02:00
b70664e2bf reorder class declarations Vse Mozhet Byt 2017-01-09 20:18:02 +02:00
b11adc4fb6 address anonymous functions Vse Mozhet Byt 2017-01-09 19:45:16 +02:00
d6b1a7121b use assignment operators Vse Mozhet Byt 2017-01-09 19:05:11 +02:00
df660d3bff fix a brace style inconsistency Vse Mozhet Byt 2017-01-09 18:51:10 +02:00
82618ee1df add break statement to prevent erroneous fall-through Vse Mozhet Byt 2017-01-09 18:43:23 +02:00
83a565eccc replace == with === Vse Mozhet Byt 2017-01-09 18:19:37 +02:00
c92b792832 use single quotes consistently Vse Mozhet Byt 2017-01-09 18:09:15 +02:00
f3f62618eb correct using of this in examples Vse Mozhet Byt 2017-01-09 17:51:57 +02:00
594dd62868 Merge branch 'master' into arrow-parens Vse Mozhet Byt 2017-01-09 17:24:18 +02:00
d279012dd4 Merge branch 'master' into simplify Vse Mozhet Byt 2017-01-09 17:22:46 +02:00
907617b8d3 Merge pull request #87 from vsemozhetbyt/const-let Ryan McDermott 2017-01-09 07:19:14 -08:00
8e469dbae5 Merge pull request #86 from Asheboy/less-fewer-grammar Ryan McDermott 2017-01-09 07:18:10 -08:00
d59f32edfd Merge pull request #76 from raerpo/fix-typo Ryan McDermott 2017-01-09 07:17:03 -08:00
3369c524e3 Merge pull request #80 from vsemozhetbyt/comment-out-ellipses Ryan McDermott 2017-01-09 07:16:16 -08:00
b3b40209b1 fix new cases with const and let Vse Mozhet Byt 2017-01-09 17:15:25 +02:00
5c2f16a7fc Merge pull request #79 from vsemozhetbyt/tabs-to-spaces Ryan McDermott 2017-01-09 07:15:19 -08:00
82f9d39b8e Merge pull request #84 from posva/patch-1 Ryan McDermott 2017-01-09 07:13:33 -08:00
86036b50db Corrects usages of less for fewer Asheboy 2017-01-09 15:11:13 +00:00
c3e754dbf7 Merge branch 'master' into fix-typo Rafael E. Poveda 2017-01-09 09:32:35 -03:00
d2d705170e Fix indentation in code Eduardo San Martin Morote 2017-01-09 11:37:18 +01:00
f4467831b0 refactor(explanatory-variables): add input example & remove first group Sébastien Elet 2017-01-08 17:11:45 +01:00
748ba65f31 Merge branch 'master' into master Hemant Pawar 2017-01-09 09:37:08 +05:30
fadfb57b94 Fill missing commas Kettan 2017-01-09 10:34:01 +08:00
73817c71d7 replace string concatenation by template literals Vse Mozhet Byt 2017-01-09 04:12:37 +02:00
eb264270a7 parenthesize arrow function arguments consistently Vse Mozhet Byt 2017-01-09 03:12:41 +02:00
f9fb07847a comment out all the ellipses consistently Vse Mozhet Byt 2017-01-09 02:57:58 +02:00
ccda22e6aa replace accidental tabs by spaces Vse Mozhet Byt 2017-01-09 02:09:40 +02:00
d2c5364717 Merge branch 'master' into master Anton Paras 2017-01-08 10:42:33 -08:00
62afdb2b03 Merge pull request #62 from vsemozhetbyt/typos Ryan McDermott 2017-01-08 10:18:35 -08:00

... 2 3 4 5 6 ...