clean-code-javascript

ryanmcdermott/clean-code-javascript

Fork 0

mirror of https://github.com/ryanmcdermott/clean-code-javascript.git synced 2026-04-04 07:42:40 +00:00

Commit Graph

Select branches

Hide Pull Requests

master

#1

#10

#100

#100

#101

#102

#103

#103

#104

#105

#106

#106

#109

#109

#11

#110

#110

#111

#114

#116

#116

#117

#117

#118

#119

#119

#12

#12

#120

#121

#123

#124

#127

#128

#13

#13

#132

#132

#134

#137

#139

#14

#14

#140

#141

#142

#142

#144

#145

#147

#149

#15

#15

#151

#151

#152

#153

#154

#154

#155

#155

#156

#157

#16

#164

#164

#165

#166

#167

#169

#169

#17

#170

#170

#171

#172

#173

#174

#174

#176

#177

#178

#178

#179

#179

#18

#182

#183

#186

#187

#188

#189

#189

#19

#191

#191

#192

#193

#194

#194

#195

#195

#196

#197

#198

#20

#202

#204

#206

#207

#208

#208

#209

#21

#210

#211

#213

#213

#215

#216

#217

#218

#218

#219

#22

#220

#221

#222

#223

#223

#224

#225

#226

#227

#228

#229

#232

#233

#234

#238

#239

#24

#240

#240

#243

#244

#246

#247

#248

#251

#251

#253

#254

#255

#256

#257

#258

#259

#26

#261

#262

#263

#264

#265

#267

#268

#269

#27

#270

#272

#273

#274

#276

#277

#279

#28

#280

#283

#284

#284

#287

#288

#289

#29

#290

#291

#297

#3

#310

#311

#312

#313

#318

#32

#320

#322

#323

#324

#325

#326

#327

#33

#331

#332

#333

#338

#339

#34

#341

#342

#344

#344

#345

#345

#346

#347

#348

#349

#349

#35

#352

#353

#353

#355

#356

#357

#357

#36

#36

#361

#361

#364

#364

#365

#365

#368

#369

#369

#37

#374

#375

#375

#376

#377

#377

#379

#379

#38

#38

#383

#385

#385

#386

#386

#39

#392

#394

#394

#395

#395

#397

#398

#399

#400

#400

#401

#401

#402

#402

#403

#403

#404

#404

#408

#408

#409

#412

#412

#413

#413

#415

#415

#417

#417

#419

#419

#421

#421

#424

#424

#426

#426

#427

#427

#428

#428

#43

#436

#436

#439

#439

#44

#44

#440

#442

#442

#443

#443

#447

#447

#448

#448

#450

#453

#453

#454

#454

#456

#456

#457

#457

#46

#47

#48

#48

#486

#486

#51

#53

#54

#56

#57

#57

#58

#6

#60

#61

#61

#62

#63

#63

#64

#65

#66

#67

#67

#68

#68

#69

#693

#693

#694

#694

#696

#696

#697

#697

#698

#698

#7

#7

#703

#703

#704

#704

#707

#709

#717

#718

#718

#719

#719

#72

#72

#720

#720

#721

#721

#722

#722

#727

#728

#728

#73

#73

#76

#77

#77

#79

#8

#80

#81

#82

#83

#84

#86

#87

#88

#89

#89

#9

#9

#90

#91

#92

#93

#94

#95

#96

#97

#98

#99

#99

3ea61da2e9 Refactor flags exmaple to be DRY Ryan McDermott 2017-01-08 10:14:38 -08:00
8d3f8da1b9 Merge pull request #56 from sney2002/patch-1 Ryan McDermott 2017-01-08 10:12:33 -08:00
ec8fd242cd Remove subsection regarding legal comments in source files Ryan McDermott 2017-01-08 10:04:02 -08:00
ac47e8231d Remove ES6 constants subsection Ryan McDermott 2017-01-08 09:59:06 -08:00
d333e12d72 Fix method chaining subsection typo Ryan McDermott 2017-01-08 09:53:54 -08:00
d28b1e3c2f Remove quip about JavaScript and Haskell being like beer types/brands Ryan McDermott 2017-01-08 09:51:29 -08:00
ce9f41fe09 Merge branch 'master' into patch-1 Christian Schlensker 2017-01-08 09:45:37 -08:00
d7cc370485 Merge branch 'master' into simplify Vse Mozhet Byt 2017-01-08 19:42:50 +02:00
2dc28e2d2e Merge branch 'master' into typos Vse Mozhet Byt 2017-01-08 19:38:40 +02:00
d35896ba9f Merge pull request #53 from DJTB/patch-2 Ryan McDermott 2017-01-08 09:35:22 -08:00
e88e5366b8 Merge pull request #66 from darahak/master Ryan McDermott 2017-01-08 09:28:44 -08:00
04c29e4c38 Merge pull request #54 from sney2002/master Ryan McDermott 2017-01-08 09:23:13 -08:00
4a2e3c4ea3 Merge pull request #58 from danielstjules/danielstjules-patch-1 Ryan McDermott 2017-01-08 09:21:01 -08:00
e9b473f834 Merge pull request #60 from rodu/minor-naming-improvement Ryan McDermott 2017-01-08 09:05:13 -08:00
576f4ef170 Merge pull request #69 from vsemozhetbyt/indentation Ryan McDermott 2017-01-08 08:58:47 -08:00
62f0b70c7f Merge pull request #51 from schoenwaldnils/master Ryan McDermott 2017-01-08 08:42:26 -08:00
9f0289bf40 fix little typo in arrow function argument's remove duplicate code section Rafael Poveda 2017-01-08 09:09:32 -03:00
9fe05688dd fixed few examples by adding missing semicolons Hemant Pawar 2017-01-07 19:19:07 +05:30
37344ac710 fix indentation in a code example Vse Mozhet Byt 2017-01-07 17:35:08 +02:00
63ca18611d Merge branch 'master' of github.com:ryanmcdermott/clean-code-javascript Nils Schönwald 2017-01-07 15:28:58 +01:00
2200e40ad5 Fix typo Nils Schönwald 2017-01-07 15:06:29 +01:00
7599859611 Mention async functions as part of ES2017 instead of ES7 (ES2016) + switch to "ES<year>/ES<edition>" when mentioning ECMAScript versions. Dara Hak 2017-01-07 14:58:18 +01:00
14e83d5ce9 use functional Array methods Vse Mozhet Byt 2017-01-07 15:37:00 +02:00
7035841c03 remove default constructors Vse Mozhet Byt 2017-01-07 15:32:37 +02:00
465f3bfd2b use object shorthand notation Vse Mozhet Byt 2017-01-07 15:23:45 +02:00
77102116a9 fix some typos in the README.md Vse Mozhet Byt 2017-01-07 15:14:26 +02:00
5d882d928d Improvement on email client function rodu 2017-01-07 11:10:13 +00:00
d6e52d5689 Add mention of jsinspect for duplicate code detection Daniel St. Jules 2017-01-06 21:49:27 -08:00
8135d47c69 use this to access object methods Jhonatan Salguero Villa 2017-01-07 00:16:13 -05:00
2da4d4b468 return true on save method to continue chaining Jhonatan Salguero Villa 2017-01-06 23:52:14 -05:00
45f40fac0f fix output in Object.assign() example Duncan Bay 2017-01-07 10:51:44 +07:00
ddd0181918 Merge pull request #43 from jordalgo/jordalgo/errorHandling Ryan McDermott 2017-01-06 19:13:30 -08:00
8be1793b33 Change Bad/Better/Best to Bad/Bad/Good Anton Paras 2017-01-06 18:37:54 -08:00
100628cd10 Add: Error Handling Section Jordalgo 2017-01-06 11:41:13 -05:00
2f1142fda3 Merge pull request #39 from acidio/master Ryan McDermott 2017-01-06 17:37:56 -08:00
7876a64afd Merge pull request #46 from stewx/patch-1 Ryan McDermott 2017-01-06 17:28:42 -08:00
17b01a2b8c Change var and let to const where necessary Nils Schönwald 2017-01-06 22:59:42 +01:00
fd293bc980 Improve example "Function names should say what they do" Tarabass 2017-01-06 20:13:30 +01:00
243a54513a Correct spelling of Cessna airplane Stewart Rand 2017-01-06 14:34:14 -04:00
64b771fa89 Adjusted the commentthat show the result Acidio Alan 2017-01-06 11:45:17 -02:00
19b1f36da1 feat(explanatory-variables): use destructuring Sébastien Elet 2017-01-06 09:38:28 +01:00
10bece91f7 Use more plausible const example Christian Schlensker 2017-01-05 23:16:50 -08:00
2837f0fe3c Merge pull request #35 from ChrisNikkel/use_const Ryan McDermott 2017-01-05 21:12:07 -08:00
08dd958d46 use const in rule "Use explanatory variables" Christopher Nikkel 2017-01-05 20:58:01 -08:00
f0278efd77 Use const instead of var Christian Schlensker 2017-01-05 20:12:23 -08:00
dfb9544da5 Rephrase default value advice Anton Paras 2017-01-05 20:11:35 -08:00
a22d1d9029 Merge pull request #32 from acparas/master Ryan McDermott 2017-01-05 20:02:28 -08:00
fa5f27d7dd Fix semantic mistake Anton Paras 2017-01-05 19:39:42 -08:00
11b7271847 Merge pull request #27 from connec/patch-1 Ryan McDermott 2017-01-05 18:34:41 -08:00
52a925173b Merge pull request #29 from jordalgo/patch-1 Ryan McDermott 2017-01-05 18:19:48 -08:00
e9044457c9 Update: promise catch logic Jordan Rome 2017-01-05 20:46:08 -05:00
55e612d676 Merge pull request #28 from tonytran1/master Ryan McDermott 2017-01-05 15:29:30 -08:00
f090f77a32 Use constants when variable values do not change tonytran1 2017-01-05 15:02:48 -08:00
c51445ef1f Merge pull request #26 from iheanyi/patch-2 Ryan McDermott 2017-01-05 14:27:17 -08:00
17a5f24a81 Remove redundant object from Object.assign example Chris Connelly 2017-01-05 21:32:53 +00:00
337fa7e961 Update README.md Iheanyi Ekechukwu 2017-01-05 15:42:16 -05:00
d00ca4c70c Fix Object.assign example Ryan McDermott 2017-01-05 07:28:49 -08:00
bd8bd1e242 Merge pull request #20 from bfred-it/patch-1 Ryan McDermott 2017-01-05 06:53:51 -08:00
2388798350 Merge pull request #21 from Chaosbohne/patch-1 Ryan McDermott 2017-01-05 06:53:01 -08:00
5cdf7a80a8 Merge pull request #22 from floriangosse/patch-1 Ryan McDermott 2017-01-05 06:51:53 -08:00
5d3bd8ae01 Merge pull request #24 from hennelh/patch-1 Ryan McDermott 2017-01-05 06:51:22 -08:00
e802380917 Update README.md Henry Harrison 2017-01-05 16:36:36 +02:00
b1ef827d91 fix(avoid-type-checking-part-1): fix variable name Florian Goße 2017-01-05 13:05:48 +01:00
08fe61e8a3 Some minor property missmatch Rico Ruszewski 2017-01-05 08:49:32 +01:00
a037f0e00b Add missing function call to "no side effects" Federico Brigante 2017-01-04 23:30:38 -08:00
2564bae26f Merge pull request #19 from gsklee/patch-2 Ryan McDermott 2017-01-04 21:17:49 -08:00
b7a5d73562 Update README.md G. Kay Lee 2017-01-05 13:11:08 +08:00
473675298f Merge pull request #18 from gsklee/patch-1 Ryan McDermott 2017-01-04 20:45:39 -08:00
4155a2b9b4 Update README.md G. Kay Lee 2017-01-05 12:42:09 +08:00
37c236c1f8 Merge pull request #17 from jsgao0/master Ryan McDermott 2017-01-04 19:16:36 -08:00
a79076f38d Update README.md Gao Jia Siang 2017-01-05 11:12:55 +08:00
c0cd8f878b Merge pull request #16 from jsgao0/master Ryan McDermott 2017-01-04 18:32:35 -08:00
b5c7100d0d Update README.md Gao Jia Siang 2017-01-05 10:29:34 +08:00
03bcebd347 Merge pull request #8 from alaycock/patch-1 Ryan McDermott 2017-01-04 17:40:42 -08:00
667ff354b2 Merge pull request #10 from Yahkob/patch-2 Ryan McDermott 2017-01-04 17:38:35 -08:00
dcbca4382a Merge pull request #11 from Yahkob/patch-4 Ryan McDermott 2017-01-04 17:34:13 -08:00
e560b130ec Merge pull request #6 from chiarafsc/master Ryan McDermott 2017-01-04 17:32:33 -08:00
20a8c6c046 Merge pull request #3 from mariotacke/fix-spelling-errors Ryan McDermott 2017-01-04 17:31:56 -08:00
ce3064476d add missing commas in objects Jake Harclerode 2017-01-04 13:46:30 -08:00
071dfdc3c7 Use explanatory variables bad and good examples should match ([1] + [2] instead of [0]) Jake Harclerode 2017-01-04 13:40:24 -08:00
b49c571697 Merge pull request #1 from alaycock/master Adam Laycock 2017-01-04 14:05:09 -07:00
95ad6fbd99 Add missing function argument in LSP section Adam Laycock 2017-01-04 14:03:49 -07:00
cc8c767686 Add getArea method where it is necessary. Adam Laycock 2017-01-04 13:56:39 -07:00
0a1fc61b2a Remove duplicate code "good" example - Remove unnecessary, misleading statement Chiara Felice Sant Cassia 2017-01-04 20:55:55 +01:00
a3e6e97a0a (docs) Correct spelling errors and remove unfinished sentence. Mario Tacke 2017-01-04 09:40:56 -08:00
bc1ae6af55 Merge pull request #1 from andrejewski/patch-1 Ryan McDermott 2017-01-04 07:28:54 -08:00
0661e527db fix "do one thing" code example Chris Andrejewski 2017-01-04 01:28:51 -05:00
55304802c8 Functions should be at one level of abstraction Ryan McDermott 2017-01-02 16:34:54 -08:00
b8b382dff9 Drive home pont of limiting function arguments Ryan McDermott 2017-01-02 16:23:38 -08:00
d783297b85 Remove subsection anchors, favor automatic marking Ryan McDermott 2017-01-02 16:11:23 -08:00
4440e35158 Attempt another GHFM link Ryan McDermott 2017-01-02 16:09:49 -08:00
8c13a414ce Add first subsection marker Ryan McDermott 2017-01-02 16:00:44 -08:00
f87128340f Single concept per test Ryan McDermott 2017-01-02 15:56:47 -08:00
8f4a8d2408 Encapsulate conditionals Ryan McDermott 2017-01-02 15:31:14 -08:00
03820514da Avoid negative conditionals Ryan McDermott 2017-01-02 15:27:55 -08:00
e7ca5c97d1 Function names should say what they do Ryan McDermott 2017-01-02 15:22:24 -08:00
f83f4e4958 Remove dead code Ryan McDermott 2017-01-02 15:07:54 -08:00
ea1735d49f Avoid positional markers Ryan McDermott 2017-01-02 15:02:29 -08:00
c080300389 Use explanatory variables Ryan McDermott 2017-01-02 14:57:34 -08:00
85bfa0c477 Add proper introduction Ryan McDermott 2017-01-02 14:43:33 -08:00

... 3 4 5 6 7 ...